Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: OPTIC-1151: Extract font family to a constant #6424

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

updating how we pulling the font-family to use css variable --font-family

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@github-actions github-actions bot added the chore label Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 05b7f64
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66f30f584459aa0008795b51
😎 Deploy Preview https://deploy-preview-6424--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 05b7f64
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66f30f58e0c73000089a3170
😎 Deploy Preview https://deploy-preview-6424--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (86c9b1e) to head (05b7f64).
Report is 38 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6424   +/-   ##
========================================
  Coverage    76.61%   76.61%           
========================================
  Files          169      169           
  Lines        13746    13746           
========================================
  Hits         10532    10532           
  Misses        3214     3214           
Flag Coverage Δ
pytests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yyassi-heartex yyassi-heartex enabled auto-merge (squash) October 3, 2024 10:29
@yyassi-heartex yyassi-heartex merged commit d3a0eb6 into develop Oct 3, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants