-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: OPTIC-1151: Extract font family to a constant #6424
Conversation
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
web/apps/labelstudio/src/components/Form/Elements/Select/Select.scss
Outdated
Show resolved
Hide resolved
web/apps/labelstudio/src/components/Form/Elements/Select/Select.scss
Outdated
Show resolved
Hide resolved
web/apps/labelstudio/src/pages/CreateProject/Config/Config.scss
Outdated
Show resolved
Hide resolved
web/apps/labelstudio/src/pages/CreateProject/Config/codemirror.css
Outdated
Show resolved
Hide resolved
web/libs/editor/src/components/SidePanels/DetailsPanel/DetailsPanel.scss
Outdated
Show resolved
Hide resolved
web/libs/editor/src/components/SidePanels/DetailsPanel/DetailsPanel.scss
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6424 +/- ##
========================================
Coverage 76.61% 76.61%
========================================
Files 169 169
Lines 13746 13746
========================================
Hits 10532 10532
Misses 3214 3214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: bmartel <[email protected]>
Co-authored-by: bmartel <[email protected]>
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
updating how we pulling the font-family to use css variable --font-family
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)